Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix install_beamsearch_decoders #7011

Merged
merged 4 commits into from
Jul 13, 2023
Merged

fix install_beamsearch_decoders #7011

merged 4 commits into from
Jul 13, 2023

Conversation

karpnv
Copy link
Collaborator

@karpnv karpnv commented Jul 11, 2023

What does this PR do ?

fix install_beamsearch_decoders.sh

Collection: ASR

Changelog

  • fix install_beamsearch_decoders.sh

Usage

  • install_beamsearch_decoders.sh work with and without root user
  • provide NEMO_PATH in the tutorial Offline_ASR.ipynb

PR Type:

  • [V ] Bugfix

Additional Information

  • Related to # 4186721

karpnv added 2 commits July 11, 2023 02:51
@karpnv
aliases
c4804aa 
Signed-off-by: Nikolay Karpov <karpnv@gmail.com>
@karpnv
add NEMO_PATH
3b0e941 
Signed-off-by: Nikolay Karpov <karpnv@gmail.com>
@github-actions github-actions bot added the ASR label Jul 11, 2023
@karpnv karpnv requested a review from titu1994 July 11, 2023 11:44
titu1994
titu1994 previously approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

scripts/asr_language_modeling/ngram_lm/install_beamsearch_decoders.sh Outdated
alias b2='./b2'
else
alias au='sudo apt-get update'
alias b2='sudo ./b2'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need better name for these alias

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@lleaver
Copy link
Contributor

lleaver commented Jul 12, 2023

For me, the updated install_beamsearch_decoders.sh script gives "command not found" on the line where the alias is used. Adding "shopt -s expand_aliases" seemed to fix it.

karpnv added 2 commits July 11, 2023 23:51
@karpnv
Merge branch 'main' of https://github.com/NVIDIA/NeMo into karpnv/ins…
6e29fad 
…tall_bs
@karpnv
expand_aliases
a7ce1b3 
Signed-off-by: Nikolay Karpov <karpnv@gmail.com>
@karpnv karpnv requested a review from titu1994 July 12, 2023 08:15
@titu1994 titu1994 merged commit 5e02346 into main Jul 13, 2023
@titu1994 titu1994 deleted the karpnv/install_bs branch July 13, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titu1994 titu1994 titu1994 approved these changes

Assignees
No one assigned
Labels
ASR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karpnv @lleaver @titu1994